Sync from GitHub (main)

src/sentinel/llm_service.py

@@ -38,12 +38,20 @@ def extract_thinking(text: str) -> tuple[str | None, str]:
     return None, text
 
 
-def get_llm(provider: str, model: str | None = None, **kwargs):
+def get_llm(
+    provider: str,
+    model: str | None = None,
+    temperature: float = 0.0,
+    top_p: float = 0.2,
+    **kwargs,
+) -> ChatGoogleGenerativeAI | ChatOllama | ChatOpenAI:
     """Return a chat model for the given provider.
 
     Args:
         provider: Provider key, e.g. "openai", "google", or "local".
         model: Optional model name.
+        temperature: Temperature for the model.
+        top_p: Top p for the model.
         **kwargs: Additional model-specific keyword arguments.
 
     Returns:
@@ -53,15 +61,17 @@ def get_llm(provider: str, model: str | None = None, **kwargs):
         ValueError: If a required API key is missing, or provider is unknown.
     """
     if provider == "local":
-        return ChatOllama(model=model, **kwargs)
+        return ChatOllama(model=model, temperature=temperature, top_p=top_p, **kwargs)
     if provider == "google":
         if not os.getenv("GOOGLE_API_KEY"):
             raise ValueError("GOOGLE_API_KEY environment variable not set")
-        return ChatGoogleGenerativeAI(model=model, **kwargs)
+        return ChatGoogleGenerativeAI(
+            model=model, temperature=temperature, top_p=top_p, **kwargs
+        )
     if provider == "openai":
         if not os.getenv("OPENAI_API_KEY"):
             raise ValueError("OPENAI_API_KEY environment variable not set")
-        return ChatOpenAI(model=model, **kwargs)
+        return ChatOpenAI(model=model, temperature=temperature, top_p=top_p, **kwargs)
     raise ValueError(f"Unknown provider: {provider}")